Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing element key for map values brick #7118

Merged
merged 1 commit into from Dec 14, 2023

Conversation

twschiller
Copy link
Contributor

@twschiller twschiller commented Dec 14, 2023

What does this PR do?

  • Fixes missing element key in brick outline for map values brick
  • Also fixes the variable being missing in the variable popover

Demo

image

Future Work

Checklist

  • Add tests
  • New files added to src/tsconfig.strictNullChecks.json (if possible): N/A
  • Designate a primary reviewer: @BLoe

@twschiller twschiller added the bug Something isn't working label Dec 14, 2023
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bcebc58) 71.10% compared to head (956b6f6) 71.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7118      +/-   ##
==========================================
- Coverage   71.10%   71.10%   -0.01%     
==========================================
  Files        1209     1209              
  Lines       37503    37505       +2     
  Branches     7068     7068              
==========================================
  Hits        26668    26668              
- Misses      10835    10837       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@twschiller twschiller added the user experience Improve the user experience (UX) label Dec 14, 2023
Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@twschiller twschiller merged commit 37db58a into main Dec 14, 2023
14 checks passed
@twschiller twschiller deleted the feature/map-values-missing-element-key branch December 14, 2023 17:33
@grahamlangford grahamlangford added this to the 1.8.5 milestone Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working user experience Improve the user experience (UX)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants