Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7119: closes the mod launcher when opening the mod activation panel #7120

Merged
merged 1 commit into from Dec 15, 2023

Conversation

grahamlangford
Copy link
Collaborator

What does this PR do?

Demo

https://www.loom.com/share/24c57de627324f24bff28248c9836890

Checklist

  • Add tests
  • Designate a primary reviewer @BLoe

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fdd0c69) 71.10% compared to head (63d2805) 71.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7120   +/-   ##
=======================================
  Coverage   71.10%   71.10%           
=======================================
  Files        1209     1209           
  Lines       37503    37504    +1     
  Branches     7068     7068           
=======================================
+ Hits        26667    26669    +2     
+ Misses      10836    10835    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

When the PR is merged, the first loom link found on this PR will be posted to #sprint-demo on Slack. Do not edit this comment manually.

@grahamlangford grahamlangford merged commit 601b4b5 into main Dec 15, 2023
14 checks passed
@grahamlangford grahamlangford deleted the fix-mod-launcher-showing-on-mod-activation branch December 15, 2023 15:10
@grahamlangford grahamlangford added this to the 1.8.5 milestone Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mod Launcher shows when activating a mod in the sidebar
2 participants