Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7113 Fix Sheets append when there are empty columns in front of headers #7308

Merged
merged 4 commits into from Jan 10, 2024

Conversation

BLoe
Copy link
Collaborator

@BLoe BLoe commented Jan 9, 2024

What does this PR do?

Demo

https://www.loom.com/share/e30ca79119ad475d96742e46c19cc747

Checklist

  • Add tests
  • New files added to src/tsconfig.strictNullChecks.json (if possible)
  • Designate a primary reviewer - @grahamlangford

@BLoe BLoe added the gdrive label Jan 9, 2024
@BLoe BLoe added this to the 1.8.7 milestone Jan 9, 2024
@BLoe BLoe added the bug Something isn't working label Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (38ec652) 72.06% compared to head (f68dea1) 72.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7308   +/-   ##
=======================================
  Coverage   72.06%   72.07%           
=======================================
  Files        1202     1202           
  Lines       37422    37420    -2     
  Branches     7018     7017    -1     
=======================================
+ Hits        26968    26970    +2     
+ Misses      10454    10450    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 9, 2024

When the PR is merged, the first loom link found on this PR will be posted to #sprint-demo on Slack. Do not edit this comment manually.

@BLoe BLoe merged commit dc328e8 into main Jan 10, 2024
16 checks passed
@BLoe BLoe deleted the bug/7113-handle-empty-columns-in-gsheets-append branch January 10, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gdrive
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blank columns at beginning of a GSheet causes content to be appended to the wrong column
2 participants