New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#7377: fix local UiPath process configuration and page editor detection #7378
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7378 +/- ##
==========================================
- Coverage 72.50% 72.50% -0.01%
==========================================
Files 1207 1207
Lines 37663 37651 -12
Branches 7062 7060 -2
==========================================
- Hits 27306 27297 -9
+ Misses 10357 10354 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that #7391 was already reviewed and merged into this PR
When the PR is merged, the first loom link found on this PR will be posted to |
@grahamlangford this will need to be cherry-picked into 1.8.7 |
…on (#7378) --------- Co-authored-by: Federico Brigante <me@fregante.com>
What does this PR do?
Remaining Work
isDevToolsPage
was failing, so we can verify other uses of the methodpageEditor.html
, which is the panel we add to the Dev Toolspixiebrix-extension/src/contrib/google/sheets/core/useCurrentOrigin.ts
Line 47 in c2a7420
pixiebrix-extension/src/telemetry/BackgroundLogger.ts
Line 75 in c2a7420
Discussion
pixiebrix-extension/src/contrib/uipath/LocalProcessOptions.tsx
Line 105 in c2a7420
Demo
Checklist
src/tsconfig.strictNullChecks.json
(if possible): N/A