Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7377: fix local UiPath process configuration and page editor detection #7378

Merged
merged 4 commits into from Jan 22, 2024

Conversation

twschiller
Copy link
Contributor

@twschiller twschiller commented Jan 19, 2024

What does this PR do?

Remaining Work

Discussion

  • Decide if we want to drop the API call to the control room to fetch the inputs. The comment here where using the brick introduces an unnecessary integration still applies:
    // FIXME: this integration use is options-only. As-is this will create an integration entry in the background.

Demo

Checklist

  • Add tests: manually tested on Windows and Mac; Jest testing the dev tools detection issue wouldn't be much value because it's so reliant on the mocking. Will add to regression testing sheet
  • New files added to src/tsconfig.strictNullChecks.json (if possible): N/A
  • Designate a primary reviewer: @grahamlangford

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (ad8cd60) 72.50% compared to head (fdfa4d6) 72.50%.

Files Patch % Lines
src/contrib/uipath/localProcess.ts 50.00% 2 Missing ⚠️
src/utils/expectContext.ts 60.00% 2 Missing ⚠️
src/pageEditor/hooks/useCurrentUrl.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7378      +/-   ##
==========================================
- Coverage   72.50%   72.50%   -0.01%     
==========================================
  Files        1207     1207              
  Lines       37663    37651      -12     
  Branches     7062     7060       -2     
==========================================
- Hits        27306    27297       -9     
+ Misses      10357    10354       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@twschiller twschiller added bug Something isn't working page editor labels Jan 19, 2024
@twschiller twschiller added this to the 1.8.7 milestone Jan 19, 2024
@fregante fregante mentioned this pull request Jan 21, 2024
2 tasks
Copy link
Collaborator

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that #7391 was already reviewed and merged into this PR

Copy link

When the PR is merged, the first loom link found on this PR will be posted to #sprint-demo on Slack. Do not edit this comment manually.

@fregante fregante changed the title #7377: fix local UiPath process configuration #7377: fix local UiPath process configuration and page editor detection Jan 22, 2024
@twschiller
Copy link
Contributor Author

@grahamlangford this will need to be cherry-picked into 1.8.7

@twschiller twschiller merged commit 76ee8fa into main Jan 22, 2024
13 checks passed
@twschiller twschiller deleted the feature/7377-uipath-local branch January 22, 2024 03:08
grahamlangford pushed a commit that referenced this pull request Jan 22, 2024
…on (#7378)

---------
Co-authored-by: Federico Brigante <me@fregante.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working page editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UiPath assistant not connecting in Page Editor
3 participants