Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce chance of piling up notifications after a reload #7383

Merged
merged 4 commits into from Jan 22, 2024

Conversation

fregante
Copy link
Collaborator

What does this PR do?

Screenshot 9

In short:

  • changes the duration from "infinity" to "20s"
  • cleans up some naming to follow existing best-practices (e.g. what unit is duration?)

Discussion

In that issue I mentioned we should remove the elements from previous installations, but in the case of the notifier, this is impossible:

  • the notification specifically appears after the invalidation, so we can't also remove it
  • technically the content scripts will be "active" until the next page reload, and they could still trigger notifications. I don’t think it's 100% safe to remove them entirely

So for this reason I think it makes sense to shorten to duration of the final notification, so eventually it will be automatically dismissed.

Checklist

  • Designate a primary reviewer: anyone

@fregante fregante added bug Something isn't working low priority labels Jan 20, 2024
@fregante fregante self-assigned this Jan 20, 2024
const { default: notify } = await import(
/* webpackMode: "lazy" */ "@/utils/notify"
/* webpackChunkName: "notify" */ "@/utils/notify"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • webpackMode: "lazy" is the default
  • webpackChunkName was only disabled because the previous webpackMode did not create a chunk

Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@fregante fregante enabled auto-merge (squash) January 22, 2024 15:25
@fregante fregante merged commit 4716134 into main Jan 22, 2024
13 checks passed
@fregante fregante deleted the F/bug/context-invalidated branch January 22, 2024 15:31
@grahamlangford grahamlangford added this to the 1.8.7 milestone Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants