Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7019: Fix "Selecting one of multiple forms in a Render Document selects all of them" #7563

Merged
merged 3 commits into from Feb 8, 2024

Conversation

fregante
Copy link
Collaborator

@fregante fregante commented Feb 8, 2024

What does this PR do?

Note that this does not affect mods created before this change

Demo

after

Checklist

@fregante fregante added bug Something isn't working page editor labels Feb 8, 2024
Co-Authored-By: Todd Schiller <1879821+twschiller@users.noreply.github.com>
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e1b8620) 72.69% compared to head (2d7b068) 72.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7563      +/-   ##
==========================================
+ Coverage   72.69%   72.71%   +0.01%     
==========================================
  Files        1220     1220              
  Lines       38111    38111              
  Branches     7168     7168              
==========================================
+ Hits        27706    27711       +5     
+ Misses      10405    10400       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@twschiller twschiller added this to the 1.8.9 milestone Feb 8, 2024
Copy link

github-actions bot commented Feb 8, 2024

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@twschiller
Copy link
Contributor

Note that this does not affect mods created before this change

The workaround for mod components created before the change is to save them an re-open them in the Page Editor. It will then re-add new instanceIds to all bricks

@fregante fregante merged commit 77707dc into main Feb 8, 2024
17 checks passed
@fregante fregante deleted the F/bug/duplicate-render-element-selection branch February 8, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working page editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selecting one of multiple forms in a Render Document selects all of them
3 participants