Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7619: add disableLoginTab option to disable automatically opening login tab #7627

Merged
merged 6 commits into from Feb 15, 2024

Conversation

twschiller
Copy link
Contributor

@twschiller twschiller commented Feb 15, 2024

What does this PR do?

Remaining Work

Demo

  • See Jest tests

Checklist

  • Add tests
  • New files added to src/tsconfig.strictNullChecks.json (if possible)
  • Designate a primary reviewer: @grahamlangford

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4df97a6) 72.74% compared to head (5823756) 72.78%.
Report is 2 commits behind head on main.

❗ Current head 5823756 differs from pull request most recent head 57f238f. Consider uploading reports for the commit 57f238f to get more accurate results

Files Patch % Lines
src/background/installer.ts 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7627      +/-   ##
==========================================
+ Coverage   72.74%   72.78%   +0.03%     
==========================================
  Files        1224     1224              
  Lines       38127    38133       +6     
  Branches     7171     7173       +2     
==========================================
+ Hits        27737    27756      +19     
+ Misses      10390    10377      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@twschiller twschiller changed the title #7619: add disableLoginTab option to disable login tab #7619: add disableLoginTab option to disable automatically opening login tab Feb 15, 2024
Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@twschiller twschiller enabled auto-merge (squash) February 15, 2024 14:55
@twschiller twschiller merged commit 4ae98a7 into main Feb 15, 2024
17 checks passed
@twschiller twschiller deleted the feature/7619-disable-login-tab branch February 15, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose managed storage option to disable SSO flow on initial startup
2 participants