persists hiding of FAB when user manually hides it #7741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7741 +/- ##
==========================================
+ Coverage 72.15% 72.16% +0.01%
==========================================
Files 1267 1267
Lines 39695 39696 +1
Branches 7369 7369
==========================================
+ Hits 28640 28645 +5
+ Misses 11055 11051 -4 ☔ View full report in Codecov by Sentry. |
grahamlangford
commented
Feb 27, 2024
| <FloatingActions /> | ||
| </Stylesheets> | ||
| </EmotionShadowRoot.div> | ||
| <PersistGate loading={<Loader />} persistor={persistor}> |
There was a problem hiding this comment.
This is the fix
grahamlangford
commented
Feb 27, 2024
| flag: "isFloatingActionButtonEnabled", | ||
| value: false, | ||
| }), | ||
| SettingsSlice.actions.setFloatingActionButtonEnabled(false), |
There was a problem hiding this comment.
Just simplifying code since this already exists.
BLoe
approved these changes
Feb 27, 2024
|
When the PR is merged, the first loom link found on this PR will be posted to |
grahamlangford
deleted the
enforce-latest-migration-version-in-persistor-configs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Reviewer Tips
Discussion
Demo
https://www.loom.com/share/56c0eea9677d4cc8b3707bfb5cfbb4e4
Checklist