Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7744: Fix integration config sanitization #7745

Merged
merged 7 commits into from Feb 28, 2024

Conversation

johnnymetz
Copy link
Collaborator

@johnnymetz johnnymetz commented Feb 27, 2024

What does this PR do?

Demo

https://www.loom.com/share/34ab7730eb1f4267b00a413b080cfd57

Checklist

  • Add tests
  • New files added to src/tsconfig.strictNullChecks.json (if possible)
  • Designate a primary reviewer: @BLoe

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.13%. Comparing base (bff97ac) to head (28f144e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7745      +/-   ##
==========================================
- Coverage   72.15%   72.13%   -0.02%     
==========================================
  Files        1267     1267              
  Lines       39706    39708       +2     
  Branches     7370     7370              
==========================================
- Hits        28650    28644       -6     
- Misses      11056    11064       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@twschiller twschiller added this to the 1.8.10 milestone Feb 28, 2024
@twschiller twschiller added bug Something isn't working regression priority labels Feb 28, 2024
Copy link

When the PR is merged, the first loom link found on this PR will be posted to #sprint-demo on Slack. Do not edit this comment manually.

@twschiller twschiller merged commit b6b555f into main Feb 28, 2024
19 checks passed
@twschiller twschiller deleted the bugfix/7744-fix-sanitize-integration-config branch February 28, 2024 12:26
name: Automation Anywhere Control Room
description: Automation Anywhere Enterprise Control Room API
url: https://docs.automationanywhere.com/bundle/enterprise-v11.3/page/enterprise/topics/control-room/control-room-api/control-room-apis.html
description: Automation Anywhere Room API
Copy link
Collaborator

@BLoe BLoe Feb 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI - typo in the description here now, missing the word "Control"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AA username/password integration definition errors due to optional folderId
3 participants