Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn of wrong lockfile changes in PR #7746

Merged
merged 3 commits into from
Feb 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/dependabot-auto-merge.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
name: Dependabot auto-approve
on: pull_request
on:
pull_request:
paths:
- package-lock.json
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated but this stops this other workflow from being activated at all on most non-dependabot PR


permissions:
contents: write
Expand Down
46 changes: 46 additions & 0 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,49 @@ jobs:
});
process.exitCode = 1;
}
lockfile:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
sparse-checkout: package-lock.json
- name: Detect changes
id: stats
run: |
git fetch origin ${{ github.base_ref }}
STAT="$(git diff --numstat origin/${{ github.base_ref }}..HEAD -- package-lock.json)"
DELETED=$(echo $STAT | cut -d " " -f 1)
ADDED=$(echo $STAT | cut -d " " -f 2)
TOTAL_CHANGES=$((DELETED + ADDED))
echo "STAT=$STAT"
echo "DELETED=$DELETED"
echo "ADDED=$ADDED"
echo "TOTAL_CHANGES=$TOTAL_CHANGES"
echo "changes=$TOTAL_CHANGES" >> $GITHUB_OUTPUT
- if: steps.stats.outputs.changes <= 1000
uses: marocchino/sticky-pull-request-comment@v2
with:
header: lockfile # Unique identifier for the comment
hide: true
- if: steps.stats.outputs.changes > 1000
uses: marocchino/sticky-pull-request-comment@v2
with:
header: lockfile # Unique identifier for the comment
recreate: true
message: |
## ⚠️ Large diff for package-lock.json

There are ${{ steps.stats.outputs.changes }} line changes in package-lock.json. This should not happen unless you're updating a lot of dependencies at once. Regenerating the lockfile should not be necessary.

If you're seeing Vercel deployment failures, this is likely the cause.

Run these commands to reset these changes:

```sh
git checkout origin/main -- package-lock.json
npm install
```
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could actually run and push this directly, but let's see how many false positives we get first.


You might want to click on "Update branch" first so that the results are accurate.
- if: steps.stats.outputs.changes > 1000
run: exit 1
Loading