-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn of wrong lockfile changes in PR #7746
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,3 +38,49 @@ jobs: | |
}); | ||
process.exitCode = 1; | ||
} | ||
lockfile: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
with: | ||
sparse-checkout: package-lock.json | ||
- name: Detect changes | ||
id: stats | ||
run: | | ||
git fetch origin ${{ github.base_ref }} | ||
STAT="$(git diff --numstat origin/${{ github.base_ref }}..HEAD -- package-lock.json)" | ||
DELETED=$(echo $STAT | cut -d " " -f 1) | ||
ADDED=$(echo $STAT | cut -d " " -f 2) | ||
TOTAL_CHANGES=$((DELETED + ADDED)) | ||
echo "STAT=$STAT" | ||
echo "DELETED=$DELETED" | ||
echo "ADDED=$ADDED" | ||
echo "TOTAL_CHANGES=$TOTAL_CHANGES" | ||
echo "changes=$TOTAL_CHANGES" >> $GITHUB_OUTPUT | ||
- if: steps.stats.outputs.changes <= 1000 | ||
uses: marocchino/sticky-pull-request-comment@v2 | ||
with: | ||
header: lockfile # Unique identifier for the comment | ||
hide: true | ||
- if: steps.stats.outputs.changes > 1000 | ||
uses: marocchino/sticky-pull-request-comment@v2 | ||
with: | ||
header: lockfile # Unique identifier for the comment | ||
recreate: true | ||
message: | | ||
## ⚠️ Large diff for package-lock.json | ||
|
||
There are ${{ steps.stats.outputs.changes }} line changes in package-lock.json. This should not happen unless you're updating a lot of dependencies at once. Regenerating the lockfile should not be necessary. | ||
|
||
If you're seeing Vercel deployment failures, this is likely the cause. | ||
|
||
Run these commands to reset these changes: | ||
|
||
```sh | ||
git checkout origin/main -- package-lock.json | ||
npm install | ||
``` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I could actually run and push this directly, but let's see how many false positives we get first. |
||
|
||
You might want to click on "Update branch" first so that the results are accurate. | ||
- if: steps.stats.outputs.changes > 1000 | ||
run: exit 1 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated but this stops this other workflow from being activated at all on most non-dependabot PR