Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7684: adds error details for multiple selectors and no selectors found errors #7752

Merged
37 changes: 37 additions & 0 deletions src/components/errors/MultipleElementsFoundErrorDetail.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
/*
* Copyright (C) 2024 PixieBrix, Inc.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/

import React from "react";
import { type MultipleElementsFoundError } from "@/errors/businessErrors";
import styles from "./ErrorDetail.module.scss";

const MultipleElementsFoundErrorDetail: React.FunctionComponent<{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like you could use a single component that takes either a MultipleElementsFoundError or NoElementsFoundError because you're relying on the same property?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I should've opened this as a draft and called it out. I kept them separate in case there were any design concerns where they would end up different.

error: MultipleElementsFoundError;
}> = ({ error: { message, selector } }) => (
<div className={styles.root}>
<div className={styles.column}>
<h5>Error</h5>
<p>{message}</p>
</div>
<div className={styles.column}>
<h5>Selector</h5>
<p>{selector}</p>
</div>
</div>
);

export default MultipleElementsFoundErrorDetail;
37 changes: 37 additions & 0 deletions src/components/errors/NoElementsFoundErrorDetail.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
/*
* Copyright (C) 2024 PixieBrix, Inc.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/

import React from "react";
import { type NoElementsFoundError } from "@/errors/businessErrors";
import styles from "./ErrorDetail.module.scss";

const NoElementsFoundErrorDetail: React.FunctionComponent<{
error: NoElementsFoundError;
}> = ({ error: { message, selector } }) => (
<div className={styles.root}>
<div className={styles.column}>
<h5>Error</h5>
<p>{message}</p>
</div>
<div className={styles.column}>
<h5>Selector</h5>
<p>{selector}</p>
</div>
</div>
);

export default NoElementsFoundErrorDetail;

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.