#7735: adds very basic null checks to prevent NPE

[grahamlangford]

What does this PR do?

• Fixes Page Editor NPE (destructure property blockId) #7735

Discussion

• Tried adding the file to tsconfig.strictNullChecks.json, but that threw 500+ errors (not surprising since it imports from editorSelectors)

Checklist

• Designate a primary reviewer @fungairino

[codecov]

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 72.14%. Comparing base (0ee8f0a) to head (aa0f4bc).
Report is 1 commits behind head on main.

Files	Patch %	Lines
...ab/editorNodeConfigPanel/EditorNodeConfigPanel.tsx	75.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7754   +/-   ##
=======================================
  Coverage   72.13%   72.14%           
=======================================
  Files        1269     1269           
  Lines       39765    39768    +3     
  Branches     7375     7378    +3     
=======================================
+ Hits        28685    28689    +4     
+ Misses      11080    11079    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[fungairino]

nit: I think this can be simplified to:

    blockConfig: { comments = {} },
  } = useSelector(selectActiveNodeInfo) ?? {};

[grahamlangford]

I think it would have to be:

  const {
    blockId: brickId,
    path: brickFieldName,
    blockConfig: { comments },
  } = useSelector(selectActiveNodeInfo) ?? { blockConfig: {} };

Which I find harder to read.

[fungairino]

Oh right, the actual right way to right this is:

  const {
    blockId: brickId,
    path: brickFieldName,
    blockConfig: { comments} = {},
  } = activeNodeInfo ?? {};

e: but in the above case comments would still be undefined, so your suggestion works better

[github-actions]

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.