New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove package config from deployments response #7808
Remove package config from deployments response #7808
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multiple new files that can probably be added to the tsconfig.strictNullChecks.json. Let me know if you need help/context with that.
Thanks @johnnymetz - a couple of callouts:
|
@johnnymetz let me know if you need help with the merge conflict. |
80f798d
to
9c58518
Compare
); | ||
const { isAutoDeploying } = useAutoDeploy({ | ||
activatableDeployments, | ||
installedExtensions: activeExtensions, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be using activate
instead of installed
as a naming convention (per the terminology guide). But updating these var names is low priority and there are many of them so I'm punting on it for now
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7808 +/- ##
==========================================
+ Coverage 72.65% 72.67% +0.01%
==========================================
Files 1274 1276 +2
Lines 39909 39950 +41
Branches 7418 7424 +6
==========================================
+ Hits 28997 29034 +37
- Misses 10912 10916 +4 ☔ View full report in Codecov by Sentry. |
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
What does this PR do?
Demo
https://www.loom.com/share/da9c92ee615540e7972d936286c5eec2
Future Work
Checklist
src/tsconfig.strictNullChecks.json
(if possible)