Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8063: improve user-visible error message for InsertAtCursorEffect brick #8069

Merged
merged 4 commits into from Mar 26, 2024

Conversation

twschiller
Copy link
Contributor

@twschiller twschiller commented Mar 26, 2024

What does this PR do?

Checklist

  • Add tests and/or storybook stories
  • Designate a primary reviewer: @grahamlangford

@twschiller twschiller changed the title #8063: improve error message for InsertAtCursorEffect brick #8063: improve user-visible error message for InsertAtCursorEffect brick Mar 26, 2024

This comment has been minimized.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 73.18%. Comparing base (17c212b) to head (403591d).

❗ Current head 403591d differs from pull request most recent head 6771ded. Consider uploading reports for the commit 6771ded to get more accurate results

Files Patch % Lines
src/bricks/effects/InsertAtCursorEffect.ts 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8069   +/-   ##
=======================================
  Coverage   73.18%   73.18%           
=======================================
  Files        1310     1310           
  Lines       40722    40747   +25     
  Branches     7567     7568    +1     
=======================================
+ Hits        29801    29821   +20     
- Misses      10921    10926    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@twschiller twschiller enabled auto-merge (squash) March 26, 2024 17:48
@twschiller twschiller merged commit 13f40b9 into main Mar 26, 2024
19 checks passed
@twschiller twschiller deleted the feature/8063-insert-error-message branch March 26, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user experience Improve the user experience (UX)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error message from Insert Text at Cursor brick
2 participants