Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in ActivateExtensionCard #8091

Merged
merged 1 commit into from Mar 29, 2024
Merged

Conversation

BLoe
Copy link
Collaborator

@BLoe BLoe commented Mar 29, 2024

What does this PR do?

Checklist

@BLoe BLoe added the bug Something isn't working label Mar 29, 2024
@BLoe BLoe self-assigned this Mar 29, 2024
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.19%. Comparing base (bd8f4c3) to head (ed0fe3a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8091   +/-   ##
=======================================
  Coverage   73.19%   73.19%           
=======================================
  Files        1310     1310           
  Lines       40737    40737           
  Branches     7567     7567           
=======================================
+ Hits        29818    29819    +1     
+ Misses      10919    10918    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@twschiller twschiller added this to the 1.8.12 milestone Mar 29, 2024
@twschiller
Copy link
Contributor

twschiller commented Mar 29, 2024

Does this fix #8057, or will there be additional work required? Update: just now saw the Slack thread

@twschiller twschiller added the user experience Improve the user experience (UX) label Mar 29, 2024
Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@mnholtz
Copy link
Collaborator

mnholtz commented Mar 29, 2024

Closes #8057

@BLoe BLoe merged commit 71182b2 into main Mar 29, 2024
22 checks passed
@BLoe BLoe deleted the dev/fix-activate-extension-card branch March 29, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working user experience Improve the user experience (UX)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ActivateExtensionCard UI/UX issues
4 participants