#8066 Handle TABLE data type in AA api responses #8155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8155 +/- ##
==========================================
- Coverage 73.36% 73.35% -0.01%
==========================================
Files 1311 1311
Lines 40661 40671 +10
Branches 7564 7566 +2
==========================================
+ Hits 29830 29836 +6
- Misses 10831 10835 +4 ☔ View full report in Codecov by Sentry. |
twschiller
reviewed
Apr 4, 2024
twschiller
reviewed
Apr 4, 2024
twschiller
reviewed
Apr 4, 2024
twschiller
reviewed
Apr 4, 2024
twschiller
reviewed
Apr 4, 2024
twschiller
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
@BLoe generally looking good - left some clarification questions/comments
|
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
twschiller
reviewed
Apr 4, 2024
| @@ -204,6 +307,23 @@ describe("selectBotOutput", () => { | |||
| baz: true, | |||
| qux: 42, | |||
| }, | |||
| out_Table: [ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Checklist