#8068: removing unnecessary css override for the button dropdown caret

[fungairino]

What does this PR do?

• Fixes Field toggle dropdown signifier doesn't show in Console/Sidebar #8068
• this css was hiding it, and now it can once again be displayed

Discussion

Let me know if there are any other placesI should check these particular uses of the dropdown (seems like the Deployment modal uses it as well).

I checked these in the PageEditor and it seems like it uses a different set of css sourced from bootstrapWithoutRem.css

Demo

Checklist

• Add tests and/or storybook stories
• Designate a primary reviewer:

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.35%. Comparing base (56f30b0) to head (5f4a804).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8162      +/-   ##
==========================================
- Coverage   73.36%   73.35%   -0.01%     
==========================================
  Files        1311     1311              
  Lines       40671    40671              
  Branches     7566     7566              
==========================================
- Hits        29839    29836       -3     
- Misses      10832    10835       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[twschiller]

We might want to tweak the vertical alignment? Right now the top of the carat seems to be at center line. Perhaps the middle of the carat should be there? Default bootstrap (and our Page Editor), for example, seems to put it centered? https://getbootstrap.com/docs/4.0/components/dropdowns/

Or it might be a product of vertical alignment for the text being off

In any case, I'd be OK release this PR as-is

@BrandonPxBx - thoughts?

[github-actions]

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

[grahamlangford]

Approved, but we should fix the alignment in a follow-on PR.

[fungairino]

The vertical alignment is slightly off. compared to the page editor. I'll see if I can adjust real quick

[fungairino]

Doesn't seem an easy fix since there's a lot of little differences that are not immediately evident. For example the border radius on focus also is not present.

For now I'll merge and we can revisit this component UX again in the future as needed.

[BrandonPxBx]

On alignment: neither of the examples are visually aligned. They're both a pixel or 2 off in the other direction -- I'd move the Page Editor one down a pixel, and the Ext. Con. up two pixel if I were being super nit picky. Consistency is probably the most important thing, though.

I'm curious because the page editor one seems to be a button component, while the console version is just an SVG (which is ironically non-focusable). Should we consider using the button component in the consoles as well?