Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8382: brick to export data url as file #8383

Merged
merged 2 commits into from
May 1, 2024
Merged

Conversation

twschiller
Copy link
Contributor

@twschiller twschiller commented May 1, 2024

What does this PR do?

Demo

Checklist

  • Add jest or playwright tests and/or storybook stories
  • Designate a primary reviewer: @fungairino

Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 73.47%. Comparing base (06960f0) to head (e095ad3).

Files Patch % Lines
src/bricks/effects/exportFileEffect.ts 83.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8383   +/-   ##
=======================================
  Coverage   73.46%   73.47%           
=======================================
  Files        1333     1334    +1     
  Lines       41238    41251   +13     
  Branches     7678     7679    +1     
=======================================
+ Hits        30297    30308   +11     
- Misses      10941    10943    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 1, 2024

Playwright test results - MV2

passed  34 passed
skipped  8 skipped

Details

report  Open report ↗︎
stats  42 tests across 16 suites
duration  7 minutes, 26 seconds
commit  e095ad3

Skipped tests

chrome › tests/extensionConsoleActivation.spec.ts › can activate a mod with built-in integration
edge › tests/extensionConsoleActivation.spec.ts › can activate a mod with built-in integration
chrome › tests/runtime/sidebarController.spec.ts › sidebar controller › shows focus dialog in top-level frame
edge › tests/runtime/sidebarController.spec.ts › sidebar controller › shows focus dialog in top-level frame
chrome › tests/runtime/sidebarNavigation.spec.ts › sidebar mod panels are persistent during navigation
chrome › tests/runtime/sidebarNavigation.spec.ts › sidebar form and temporary panels are unavailable after navigation
edge › tests/runtime/sidebarNavigation.spec.ts › sidebar mod panels are persistent during navigation
edge › tests/runtime/sidebarNavigation.spec.ts › sidebar form and temporary panels are unavailable after navigation

Copy link

github-actions bot commented May 1, 2024

Playwright test results - MV3

passed  42 passed

Details

report  Open report ↗︎
stats  42 tests across 16 suites
duration  10 minutes, 56 seconds
commit  e095ad3

Copy link

github-actions bot commented May 1, 2024

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@twschiller twschiller added this to the 1.8.14 milestone May 1, 2024
@twschiller twschiller requested a review from fregante May 1, 2024 00:20
@@ -0,0 +1,40 @@
/*
* Copyright (C) 2024 PixieBrix, Inc.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

30 strict null check errors due to messenger

@twschiller twschiller requested review from grahamlangford and removed request for fregante May 1, 2024 00:23
@twschiller twschiller enabled auto-merge (squash) May 1, 2024 00:23
@twschiller twschiller merged commit 8e5d11f into main May 1, 2024
35 of 36 checks passed
@twschiller twschiller deleted the feature/8382-export-file branch May 1, 2024 00:29
super(
"@pixiebrix/export/file",
"[Experimental] Export as File",
"Export/download a data URL as a file",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd probably just name this "Save to file" and (optionally?) use this new API https://developer.mozilla.org/en-US/docs/Web/API/Window/showSaveFilePicker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brick customer Required for a customer projct
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants