Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Shockwave Filter Deprecations #435

Merged
merged 4 commits into from
Feb 14, 2024
Merged

Conversation

bbazukun123
Copy link
Collaborator

  • Add deprecations for the Shockwave filter.
  • Use GpuProgram.from and GlProgram.from for caching.

Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're only moving time to the options, we likely don't even need the DeprecatedShockwaveFilterOptions interface, you can do this Omit<ShockwaveFilterOptions, 'time'>

src/shockwave/ShockwaveFilter.ts Outdated Show resolved Hide resolved
src/shockwave/ShockwaveFilter.ts Outdated Show resolved Hide resolved
src/shockwave/ShockwaveFilter.ts Outdated Show resolved Hide resolved
@bigtimebuddy bigtimebuddy merged commit fcfaa83 into main Feb 14, 2024
2 checks passed
@bigtimebuddy bigtimebuddy deleted the chore-deprecation-shockwave branch February 14, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants