Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to monorepo #364

Merged
merged 9 commits into from
Jan 17, 2023
Merged

Convert to monorepo #364

merged 9 commits into from
Jan 17, 2023

Conversation

baseten
Copy link
Collaborator

@baseten baseten commented Dec 28, 2022

Depends on: https://github.com/pixijs/pixi-react/pull/363/files
Part of: https://github.com/play-co/react-pixi/issues/10

Changes

  • Move existing code into separate packages: pixi-react, pixi-react-legacy, animated
  • Add new animated-legacy package since animated is now a small additional lib with pixi-react as a peer dep, so animated-legacy required for pixi-react-legacy
  • Split out TYPES to separate package for easier inclusion
  • Add eslint and ts configs as packages
  • Add nx
  • Make eslint work globally as well as per package for husky compatibility
  • Until Remove warnings when linting ignored files eslint/eslint#15010 is resolved remove max-warnings 0 from lint-staged command

@baseten baseten requested a review from Zyie December 28, 2022 13:33
@baseten baseten mentioned this pull request Dec 30, 2022
@baseten
Copy link
Collaborator Author

baseten commented Dec 30, 2022

@Zyie if you're uncertain about setting up the eslint config as a package, I ended up reverting it in the next PR because it was causing more hindrance than help! #366

Base automatically changed from update-repo-structure to master January 17, 2023 13:13
@baseten baseten merged commit 58457b2 into master Jan 17, 2023
@baseten baseten deleted the convert-to-mono branch January 17, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants