Fix BitmapText double destroy bug
#378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baseten
commented
Jan 19, 2023
Comment on lines
+40
to
+41
| // TODO: should we call willUnmount anyway irrespective of whether destroyChildren is true? | ||
| willUnmountRecursive(c, child); |
There was a problem hiding this comment.
@Zyie I'm wondering whether we should just call willUnmount on children anyway whether or not destroyChildren is true - technically the child is about to unmount irrespective of whether it's being destroyed
Zyie
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #367
Changes
willUnmountiteratively during unmountwillUnmount/destroycalls