Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes iOS11 bug #72

Merged
merged 3 commits into from
Aug 22, 2018
Merged

Fixes iOS11 bug #72

merged 3 commits into from
Aug 22, 2018

Conversation

telime
Copy link
Contributor

@telime telime commented Aug 20, 2018

ios11 safari's webkitOfflineAudioContext allows only 44100 Hz sample rate
if not set 44100 Hz, safari is throw exception "SyntaxError: The string did not match the expected pattern.."

ios11 safari's webkitAudioContext allows only 44100 Hz sample rate
Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Could you please add an inline comment mentioning iOS 11 as the reason for the 44100?

@telime
Copy link
Contributor Author

telime commented Aug 21, 2018

Thank you for your response!
I tried putting comments according to your suggestions, How does that look?

@bigtimebuddy bigtimebuddy merged commit 21c2d8a into pixijs:master Aug 22, 2018
@bigtimebuddy
Copy link
Member

Looks great! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants