Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLRenderer flips Y when masking into a render texture #1493

Closed
davidfig opened this issue Mar 6, 2015 · 3 comments
Closed

WebGLRenderer flips Y when masking into a render texture #1493

davidfig opened this issue Mar 6, 2015 · 3 comments
Labels
🕷 Bug Verified that it’s actually a legit bug that exists in the current release.
Milestone

Comments

@davidfig
Copy link
Contributor

davidfig commented Mar 6, 2015

This was a comment to the closed issue #1258 by NikkiKoole:

Since f3730f1 that change I have some problems with renderTextures (without using masks) It only appears in one of the DisplayObjectContainer's children, but the fix is just to set this.renderSession.flipY = 1; in WebGLRenderer.renderDisplayObject, I'll try to make a self contained example because atm I am seeing this in a very large project of mine... (nearing deadline ;))

I ran into the same issue, where a DisplayObjectContainer's children were flipped during a renderTexture.render() call. The fix is what NikkiKoole mentioned:

In the following line of PIXI.WebGLRenderer.prototype.renderDisplayObject()

// make sure to flip the Y if using a render texture..
this.renderSession.flipY = buffer ? -1 : 1;

becomes

// make sure to flip the Y if using a render texture..
this.renderSession.flipY = 1;

change it so flipY to be always 1.

I'm sure there's a reason for this check, but removing it fixes the issue.

@GoodBoyDigital
Copy link
Member

All fixed in v3 :)

@davidfig
Copy link
Contributor Author

davidfig commented Mar 6, 2015

Can't wait to get my grubby hands on v. 3.

@englercj englercj closed this as completed Mar 6, 2015
@englercj englercj added 🕷 Bug Verified that it’s actually a legit bug that exists in the current release. WebGL labels Mar 6, 2015
@englercj englercj added this to the v3.x milestone Mar 6, 2015
@lock
Copy link

lock bot commented Feb 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Feb 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕷 Bug Verified that it’s actually a legit bug that exists in the current release.
Projects
None yet
Development

No branches or pull requests

3 participants