Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application loader support #3909

Merged
merged 5 commits into from
Apr 10, 2017
Merged

Application loader support #3909

merged 5 commits into from
Apr 10, 2017

Conversation

bigtimebuddy
Copy link
Member

@bigtimebuddy bigtimebuddy commented Apr 4, 2017

Adds convenience support for loader to the Application class.

const app = new PIXI.Application();

// Pause rendering
app.stop(); 

// Load some resources
app.loader
    .add('logo', 'images/logo.png');
    .load(() => {
       app.start(); // resume rendering
    });

Added

  • Adds loader property the Application class, e.g., app.loader.load()
  • Adds constructor argument options.sharedLoader to Application to opt-in to using the shared Loader.
  • Adds PIXI.loaders.shared as an alias for PIXI.loader (conforms to Ticker usage PIXI.ticker.shared).

Fixed

  • Fixes issue when excluding the loaders module npm run dist — -e loaders (deprecations were throwing issues for deprecated Resource, e.g. 'isJson`, etc).

@bigtimebuddy bigtimebuddy added Difficulty: Easy 👀 Needs Review PR needs to be reviewed by someone on the core team. 🥶 Low Priority Generally issues or PRs that don’t need to make it into the next release. 🙏 Feature Request Community request for new features, APIs, packages. 💾 v4.x (Legacy) Legacy version 4 support labels Apr 4, 2017
Copy link
Member

@englercj englercj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, not crazy about the PIXI.loader -> PIXI.loaders.shared change, since this is something that is so commonly used. But I also don't feel that strongly about it.

@bigtimebuddy
Copy link
Member Author

@englercj Fair point. I re-added PIXI.loader.

@bigtimebuddy bigtimebuddy merged commit 44df412 into dev Apr 10, 2017
@bigtimebuddy bigtimebuddy deleted the loader-fixes branch April 10, 2017 12:38
@lock
Copy link

lock bot commented Feb 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Feb 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🙏 Feature Request Community request for new features, APIs, packages. 🥶 Low Priority Generally issues or PRs that don’t need to make it into the next release. 👀 Needs Review PR needs to be reviewed by someone on the core team. 💾 v4.x (Legacy) Legacy version 4 support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants