Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add property to Renderer Plugins #6879

Merged
merged 3 commits into from
Sep 16, 2020
Merged

Add property to Renderer Plugins #6879

merged 3 commits into from
Sep 16, 2020

Conversation

Bouh
Copy link
Contributor

@Bouh Bouh commented Sep 15, 2020

Description of change

Fix #6878
Add missing properties:
-PIXI.ParticleRenderer
-PIXI.BatchRenderer
-PIXI.TilingSpriteRenderer

Pre-Merge Checklist
  • Documentation is changed or added
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

First PR here 🥳

Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bouh, thanks so much for the PR! Appreciate the help and hope you'll continue to contribute.

I made some small tweaks to the descriptions and the comment format. FYI, it should be in this format:

@property {[type]} [name] [desc]

Otherwise looks good. I also noticed that BatchRenderer isn't in the docs and should be, but we can clean that up later.

@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Sep 15, 2020
@ShukantPal
Copy link
Member

@bigtimebuddy This is a bit of task to do at webdoc - it doesn't support symbols with the same path. (i.e. it can't track two classes with the same name as PIXI.BatchRenderer). Same with PIXI.Graphics#lineStyle.

This wasn't an issue with PixiJS documentation standalone. But I'll have to solve it before releasing webdoc for pixi-api & before we strip the PIXI namespace. That's because PIXI.BatchRenderer and PIXI.brend.BatchRenderer (from pixi-batch-renderer) will clash.

@bigtimebuddy bigtimebuddy merged commit 89779ae into pixijs:dev Sep 16, 2020
@bigtimebuddy
Copy link
Member

Thank you 🎉!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Renderer Plugins in Documentation
4 participants