Readability fixes

pixijs · Apr 15, 2024 · 387ac12 · 387ac12
1 parent c93b4e9
commit 387ac12
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/rendering/renderers/gl/geometry/GlGeometrySystem.ts b/src/rendering/renderers/gl/geometry/GlGeometrySystem.ts
@@ -408,7 +408,7 @@ export class GlGeometrySystem implements System
                     {
                         // Can't use truthiness check to determine if divisor is set,
                         // since 0 is a valid value for divisor
-                        const divisor = 'divisor' in attribute ? attribute.divisor : 1;
+                        const divisor = attribute.divisor ?? 1;
 
                         gl.vertexAttribDivisor(location, divisor);
                     }

diff --git a/src/rendering/renderers/gpu/pipeline/PipelineSystem.ts b/src/rendering/renderers/gpu/pipeline/PipelineSystem.ts
@@ -313,11 +313,12 @@ export class PipelineSystem implements System
             {
                 const attribute = geometry.attributes[i];
 
-                if ('divisor' in attribute)
+                if ((attribute.divisor ?? 1) !== 1)
                 {
                     // TODO: Maybe emulate divisor with storage_buffers/float_textures?
                     // For now just issue a warning
-                    warn(`Attribute ${i} has 'divisor' field set, which is currently unsupported in WebGPURenderer.`);
+                    warn(`Attribute ${i} has an invalid divisor value of '${attribute.divisor}'. `
+                        + 'WebGPU only supports a divisor value of 1');
                 }
 
                 if (attribute.buffer === buffer)