fix: uninstalling bitmap font containing space characters

pixijs · May 23, 2024 · c8d2fbc · c8d2fbc
1 parent 8bec73b
commit c8d2fbc
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/scene/text-bitmap/AbstractBitmapFont.ts b/src/scene/text-bitmap/AbstractBitmapFont.ts
@@ -191,7 +191,8 @@ export abstract class AbstractBitmapFont<FontType>
 
         for (const i in this.chars)
         {
-            this.chars[i].texture.destroy();
+            // texture may not exist if the char is " ", \n, \r, or \t.
+            this.chars[i].texture?.destroy();
         }
 
         (this.chars as null) = null;

diff --git a/tests/renderering/text/BitmapFontManager.test.ts b/tests/renderering/text/BitmapFontManager.test.ts
@@ -17,6 +17,15 @@ describe('BitmapFontManager', () =>
         expect(bitmapFont).toBeDefined();
     });
 
+    it('should uninstall and remove from Cache if char is empty', () =>
+    {
+        BitmapFontManager.install('foo', {}, { chars: ' ' });
+        expect(Cache.get<BitmapFont>('foo-bitmap')).toBeDefined();
+
+        BitmapFontManager.uninstall('foo');
+        expect(Cache.get<BitmapFont>('foo-bitmap')).toBeUndefined();
+    });
+
     it('should uninstall and remove from Cache', () =>
     {
         BitmapFontManager.install('foo', {}, { chars: 'a' });