Chore: Jest running on Windows (#8864)

pixijs · Dec 12, 2022 · fd4cf83 · fd4cf83
1 parent 01ab1aa
commit fd4cf83
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 2 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -77,6 +77,7 @@
     "rollup-plugin-rename-node-modules": "^1.3.1",
     "rollup-plugin-sourcemaps": "^0.4.2",
     "rollup-plugin-string": "^3.0.0",
+    "tree-kill": "^1.2.2",
     "ts-jest": "^26.0.0",
     "ts-node": "^9.0.0",
     "tsconfig-paths": "^3.10.1",

diff --git a/test/jest-global-setup.ts b/test/jest-global-setup.ts
@@ -6,7 +6,14 @@ module.exports = async function ()
 {
     if (!process.env.GITHUB_ACTIONS)
     {
-        const httpServerProcess = spawn('http-server', ['-c-1', `${join(process.cwd(), './packages')}`]);
+        const httpServerProcess = spawn(
+            'http-server',
+            ['-c-1', `${join(process.cwd(), './packages')}`],
+            {
+                // See https://nodejs.org/api/child_process.html#spawning-bat-and-cmd-files-on-windows
+                shell: process.platform === 'win32',
+            },
+        );
 
         // eslint-disable-next-line @typescript-eslint/ban-ts-comment
         // @ts-ignore

diff --git a/test/jest-global-teardown.ts b/test/jest-global-teardown.ts
@@ -1,4 +1,5 @@
 import type { ChildProcess } from 'child_process';
+import kill from 'tree-kill';
 
 // eslint-disable-next-line func-names
 module.exports = async function ()
@@ -14,7 +15,7 @@ module.exports = async function ()
             httpServerProcess.on('close', resolve);
         });
 
-        httpServerProcess.kill();
+        kill(httpServerProcess.pid);
         await processClose;
     }
 };