Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: [v8] text.style.fill === null when TextStyle is reused instead of TextStyleOptions #10328

Closed
joergplewe opened this issue Mar 14, 2024 · 2 comments · Fixed by #10355
Closed
Assignees
Labels
🕷 Bug Verified that it’s actually a legit bug that exists in the current release. v8

Comments

@joergplewe
Copy link

joergplewe commented Mar 14, 2024

Current Behavior

In case a TextStyle object - in favor of a TextStyleOptions type - is used to create multiple Text objects, these may loose their style.fill property, which e.g. makes tinting impossible.

Expected Behavior

Text should well-behave concerning it's way of construction.

Steps to Reproduce

https://www.pixiplayground.com/#/edit/-V-yqUNla6o8sOKEEKRCk

See that tinting gets lost after 2 seconds and recreation of scenegraph content.

Environment

Possible Solution

I suspect this has to do with caching and reference counting of ressources.

Additional Information

No response

@joergplewe joergplewe changed the title Bug: text.style.fill === null when TextStyle is reused instead of TextStyleOptions Bug: [V8] text.style.fill === null when TextStyle is reused instead of TextStyleOptions Mar 14, 2024
@joergplewe joergplewe changed the title Bug: [V8] text.style.fill === null when TextStyle is reused instead of TextStyleOptions Bug: [v8] text.style.fill === null when TextStyle is reused instead of TextStyleOptions Mar 14, 2024
@bigtimebuddy bigtimebuddy added 🕷 Bug Verified that it’s actually a legit bug that exists in the current release. v8 labels Mar 15, 2024
@bigtimebuddy
Copy link
Member

Thanks for reporting @joergplewe. This indeed looks like a bug.

@GoodBoyDigital
Copy link
Member

Hey chaps, looking at the code - currently we destroy a texture style when we destroy a text.
will make it optional (like textures and their sources!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕷 Bug Verified that it’s actually a legit bug that exists in the current release. v8
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants