Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: allow for optional destruction of textStyle #10355

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Conversation

GoodBoyDigital
Copy link
Member

@GoodBoyDigital GoodBoyDigital commented Mar 21, 2024

Text style is not destroyed by default now - which make more sense (a bit like texture and texture sources)

to destroy the style you can now do:


fixes #10328
myText.destroy(true);

// or more granuler

myText.destroy({style:true});

fixes #10328

Copy link

codesandbox-ci bot commented Mar 21, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c96e892:

Sandbox Source
pixi.js-sandbox Configuration

@Zyie Zyie changed the title v8 allow for optional destruction of textStyle Fix: allow for optional destruction of textStyle Mar 21, 2024
@Zyie Zyie added the v8 label Mar 21, 2024
@Zyie Zyie added this pull request to the merge queue Mar 21, 2024
Merged via the queue into dev with commit 634eec0 Mar 21, 2024
4 checks passed
@Zyie Zyie deleted the bugfix/v8-destroy-text-style branch March 21, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: [v8] text.style.fill === null when TextStyle is reused instead of TextStyleOptions
2 participants