Bug: Update Matrix uniforms crashes V8

[shirecoding]

Current Behavior

Unable to update uniform matrix in shader by setting the matrix as container's worldTransform

Expected Behavior

Should be able to update the uniform matrix by passing in the worldStage container's worldTransform

Steps to Reproduce

With the following shader

Shader.from({
        gl: shaders[s],
        resources: {
            uTexture: texture.source,
            uniforms: {
                uWorldStageTransform: { <----- this crashes
                    value: new Matrix(),
                    type: "mat3<f32>",
                },
                uTx: { <---- this works
                    value: 0,
                    type: "f32",
                },
                uTy: {
                    value: 0,
                    type: "f32",
                },
                uTextureHeight: {
                    value: pixelHeight,
                    type: "f32",
                },
                uTextureWidth: {
                    value: pixelWidth,
                    type: "f32",
                },
            },
        },
    });

Updating the uniforms

// This crashes
shader.resources.uniforms.uniforms.uWorldStageTransform.a =
worldStage.worldTransform;
(in the vert shader)
mat3 mvp = uProjectionMatrix * uWorldTransformMatrix * uWorldStageTransform * uTransformMatrix;

// This works
shader.resources.uniforms.uniforms.uTx = t.tx;
shader.resources.uniforms.uniforms.uTy = t.ty;
(in the vert shader)
gl_Position = vec4((mvp * vec3(aPosition + aInstancePosition + vec2(uTx, uTy), 1.0)).xy, 0.0, 1.0) ;

error:

Uncaught TypeError: Cannot read properties of undefined (reading 'replace')
    at generateUniformsSync (generateUniformsSync.ts:75:57)
    at GlUniformGroupSystem._generateUniformsSync (GlUniformGroupSystem.ts:102:16)
    at GlUniformGroupSystem._createUniformSyncFunction (GlUniformGroupSystem.ts:92:36)
    at GlUniformGroupSystem._getUniformSyncFunction (GlUniformGroupSystem.ts:80:21)
    at GlUniformGroupSystem.updateUniformGroup (GlUniformGroupSystem.ts:66:35)
    at eval (eval at generateShaderSyncCode (GenerateShaderSyncCode.ts:112:12), <anonymous>:20:29)
    at GlShaderSystem.bind (GlShaderSystem.ts:95:22)
    at GlEncoderSystem.draw (GlEncoderSystem.ts:56:25)
    at GlMeshAdaptor.execute (GlMeshAdaptor.ts:83:26)
    at MeshPipe.execute (MeshPipe.ts:193:23)

Environment

Pixi: 8.1.4

Possible Solution

No response

Additional Information

No response

[GoodBoyDigital]

heya! please can you provide this as a playground? I can then help address! thanks!

[shirecoding]

Sure, here it is

https://www.pixiplayground.com/#/edit/ygcHzzCAKj51Z4OBlFQ26

you can uncomment out the part that works to see that the bunny is offset to 100 px

[GoodBoyDigital]

heya, the type should be mat3x3<f32>

pixijs/src/rendering/renderers/shared/shader/types.ts

Line 2 in 9fd9c46

export type UNIFORM_TYPES_SINGLE =

[GoodBoyDigital]

If you are using TS, it should give type safety! The PR should make it easier to catch in the future for js too! #10562

[shirecoding]

ahh i see, i was using typescript, but it doesnt report the type errors somehow in VS code, it says it should be type string