New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transparent WebM videos do not render correctly #3526
Comments
Interesting point - this only happens for WebGL. It displays fine on Canvas renderer |
@themoonrat Anything new regarding this issue? |
Honestly not sure if this is a pixi bug since we just pass the video directly to the gl context as a texture and the browser takes care of it. |
@englercj It seems to be a pixi4 problem |
@englercj Me and my colleague @pietervanneste did some investagation. It seems that following part is causing the problem. if(newHeight !== this.height || newWidth !== this.width)
{
gl.texImage2D(gl.TEXTURE_2D, 0, this.format, this.format, this.type, source);
}
else
{
gl.texSubImage2D(gl.TEXTURE_2D, 0, 0, 0, this.format, this.type, source);
} If we change it to gl.texImage2D(gl.TEXTURE_2D, 0, this.format, this.format, this.type, source); so we don't call gl.texSubImage2D, It seems to clear the texture after every frame. |
I can confirm that @barbarosso's fix does indeed work. Can we please get this fix applied to the latest version of Pixi.js as soon as possible? |
I believe this is fixed in v5 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
It seems that previously rendered video frames are not cleared:
https://jsfiddle.net/vm4h4928/
I dived into the code but could not find the cause of this issue. All you do is upload the texture, but this should also include transparent pixels?
The text was updated successfully, but these errors were encountered: