Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PREFER_ENV default #7899

Closed
dev7355608 opened this issue Oct 22, 2021 · 4 comments · Fixed by #7974
Closed

PREFER_ENV default #7899

dev7355608 opened this issue Oct 22, 2021 · 4 comments · Fixed by #7974
Assignees

Comments

@dev7355608
Copy link
Collaborator

The doc says that webgl2 is disabled by default for all non-apple mobile devices, but it's actually disabled for all mobile devices.

Also the referenced bug has been fixed two years ago. Maybe we can remove this exception for mobile devices?

/**
* The maximum support for using WebGL. If a device does not
* support WebGL version, for instance WebGL 2, it will still
* attempt to fallback support to WebGL 1. If you want to
* explicitly remove feature support to target a more stable
* baseline, prefer a lower environment.
*
* Due to {@link https://bugs.chromium.org/p/chromium/issues/detail?id=934823|bug in chromium}
* we disable webgl2 by default for all non-apple mobile devices.
*
* @static
* @name PREFER_ENV
* @memberof PIXI.settings
* @type {number}
* @default PIXI.ENV.WEBGL2
*/
settings.PREFER_ENV = isMobile.any ? ENV.WEBGL : ENV.WEBGL2;

@ShukantPal
Copy link
Member

@ivanpopelyshev @GoodBoyDigital What do you think?

@ivanpopelyshev
Copy link
Collaborator

I say that we assign one of us to answer issues if something goes wrong with that thing :) @GoodBoyDigital do you have anyone?

@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Previously “Won’t Fix”, bots should tag with this for inactive issues or pull-requests. label Mar 2, 2022
@stale stale bot closed this as completed Apr 17, 2022
@dev7355608 dev7355608 reopened this Apr 17, 2022
@stale stale bot removed the Stale Previously “Won’t Fix”, bots should tag with this for inactive issues or pull-requests. label Apr 17, 2022
@Zyie
Copy link
Member

Zyie commented Jul 1, 2022

Fixed in #7899 and will be released in v7

@Zyie Zyie closed this as completed Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants