Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 'once' option to FederatedEventTarget.addEventListener #10046

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

jmcclell
Copy link

@jmcclell jmcclell commented Jan 3, 2024

This change brings the addEventListener implementation more in line with the DOM implementation.

Description of change

Adds support for the 'once' option to the addEventListener method of FederatedEventTarget. This makes this method more congruent with the DOM implementation.

Pre-Merge Checklist
  • Tests and/or benchmarks are included
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

This change brings the addEventListener implementation more in line with
the DOM implementation.
Copy link

codesandbox-ci bot commented Jan 3, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a066d61:

Sandbox Source
pixi.js-sandbox Configuration

@jmcclell
Copy link
Author

jmcclell commented Jan 3, 2024

Related to #10043

Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean, nice work. We'll have to resolve conflicts with the signals PR, but that should be easy. I'll probably merge this one first.

@bigtimebuddy bigtimebuddy added this to the v7.4.0 milestone Jan 3, 2024
@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Jan 3, 2024
@Zyie Zyie added the 💞 Migrate to v8 This PR needs to be migrated to v8 label Jan 3, 2024
@bigtimebuddy bigtimebuddy merged commit a369b8f into pixijs:dev Jan 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💞 Migrate to v8 This PR needs to be migrated to v8 ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants