-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking: load svgs as texture instead of graphics by default #10091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b0e0554:
|
Zyie
changed the title
Fix: load graphics as texture instead of graphics by default
Breaking: load graphics as texture instead of graphics by default
Jan 9, 2024
Zyie
changed the title
Breaking: load graphics as texture instead of graphics by default
Breaking: load svgs as texture instead of graphics by default
Jan 9, 2024
GoodBoyDigital
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ship it!
* added context loss set up to WebGL * random fix? * set values back * disable context loss * only run context loss tests locally * delete the context loss tests * change what we run on * Tweaks to visual tests (#10100) * make tests reuse the renderer * doc update * fix lint * increase jest --------- Co-authored-by: Zyie <24736175+Zyie@users.noreply.github.com> --------- Co-authored-by: Zyie <24736175+Zyie@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.