Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: load svgs as texture instead of graphics by default #10091

Merged
merged 13 commits into from
Jan 11, 2024

Conversation

Zyie
Copy link
Member

@Zyie Zyie commented Jan 9, 2024

No description provided.

Copy link

codesandbox-ci bot commented Jan 9, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b0e0554:

Sandbox Source
pixi.js-sandbox Configuration

@Zyie Zyie added the v8 label Jan 9, 2024
@Zyie Zyie changed the title Fix: load graphics as texture instead of graphics by default Breaking: load graphics as texture instead of graphics by default Jan 9, 2024
@Zyie Zyie changed the title Breaking: load graphics as texture instead of graphics by default Breaking: load svgs as texture instead of graphics by default Jan 9, 2024
@Zyie Zyie marked this pull request as draft January 9, 2024 19:51
@Zyie Zyie marked this pull request as ready for review January 10, 2024 14:43
@Zyie Zyie self-assigned this Jan 10, 2024
Copy link
Member

@GoodBoyDigital GoodBoyDigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it!

* added context loss set up to WebGL

* random fix?

* set values back

* disable context loss

* only run context loss tests locally

* delete the context loss tests

* change what we run on

* Tweaks to visual tests (#10100)

* make tests reuse the renderer

* doc update

* fix lint

* increase jest

---------

Co-authored-by: Zyie <24736175+Zyie@users.noreply.github.com>

---------

Co-authored-by: Zyie <24736175+Zyie@users.noreply.github.com>
@Zyie Zyie merged commit 3baa504 into next-v8 Jan 11, 2024
3 checks passed
@Zyie Zyie deleted the chore/v8-svg-image branch January 11, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants