Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: issues with TextStyle getter/setters and BitmapText default fill #10095

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Fix: issues with TextStyle getter/setters and BitmapText default fill #10095

merged 1 commit into from
Jan 11, 2024

Conversation

Zyie
Copy link
Member

@Zyie Zyie commented Jan 10, 2024

This PR fixes a couple of issues with TextStyle

  • the setters did not have the logic that was in the constructor
  • dropShadow is now fully supported as either a bool or an object and will apply defaults if a partial style is provided
  • stroke now checks for _originalStroke instead of _originalFill
  • when converting from v7 drop shadow options the default settings are now applied

This PR also fixes the issue where bitmap texts fill was always being set to white

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jan 10, 2024 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6a51e28:

Sandbox Source
pixi.js-sandbox Configuration

@Zyie Zyie marked this pull request as ready for review January 10, 2024 14:42
@Zyie Zyie self-assigned this Jan 10, 2024
@Zyie Zyie added the v8 label Jan 10, 2024
GoodBoyDigital
GoodBoyDigital approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@GoodBoyDigital GoodBoyDigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@Zyie Zyie merged commit 3597573 into next-v8 Jan 11, 2024
3 checks passed
@Zyie Zyie deleted the fix/text-styles branch January 11, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GoodBoyDigital GoodBoyDigital GoodBoyDigital approved these changes

Assignees

@Zyie Zyie

Labels
v8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Zyie @GoodBoyDigital