-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: split CI into multiple workflows #10109
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 955200d:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
The node/npm versions are spread all over the place as inputs of the setup workflow. It would be easier to manage if you just declared that in one place (or used the input default). |
Otherwise, love the modularity of these workflows. Great job! |
This PR splits the
node.yml
file up into multiple reusable partsThe main reason for this change is that with visual testing we started hitting the limits on what a single workflow could handle and had errors that are not present locally. These issues went away when we changed to a more powerful runner, however the costs are pretty high.
So the solution is multiple workflows that split the unit and visual testing up
Changes
pull-unit.yml
- runs linting/type checking, runs unit tests, tests building the projectpull-visuals.yml
- runs visual testspush.yml
- will deploy non tagged branches to s3. Will no longer do any sort of validation, only builds and uploads. I figure that the PR workflows handle this and the main reason for the upload is to more easily test docs/buildsrelease-unit.yml
- same aspull-unit.yml
without the build steprelease-visuals.yml
- same aspull-visuals.yml
release.yml
- This workflow depends on the other two release workflows to be completed, then will build, upload and release the project