Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: split CI into multiple workflows #10109

Merged
merged 9 commits into from
Jan 15, 2024
Merged

Chore: split CI into multiple workflows #10109

merged 9 commits into from
Jan 15, 2024

Conversation

Zyie
Copy link
Member

@Zyie Zyie commented Jan 12, 2024

This PR splits the node.yml file up into multiple reusable parts

The main reason for this change is that with visual testing we started hitting the limits on what a single workflow could handle and had errors that are not present locally. These issues went away when we changed to a more powerful runner, however the costs are pretty high.

So the solution is multiple workflows that split the unit and visual testing up

Changes

  • added a couple of reusable actions for linting/testing/setup

  • pull-unit.yml - runs linting/type checking, runs unit tests, tests building the project
  • pull-visuals.yml - runs visual tests

  • push.yml - will deploy non tagged branches to s3. Will no longer do any sort of validation, only builds and uploads. I figure that the PR workflows handle this and the main reason for the upload is to more easily test docs/builds

  • release-unit.yml - same as pull-unit.yml without the build step
  • release-visuals.yml - same as pull-visuals.yml
  • release.yml - This workflow depends on the other two release workflows to be completed, then will build, upload and release the project

Copy link

codesandbox-ci bot commented Jan 12, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 955200d:

Sandbox Source
pixi.js-sandbox Configuration

@Zyie Zyie changed the title WIP: fix ci Chore: split CI into multiple workflows Jan 12, 2024
@Zyie Zyie marked this pull request as ready for review January 12, 2024 16:06
Copy link
Member

@GoodBoyDigital GoodBoyDigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@Zyie Zyie self-assigned this Jan 12, 2024
@Zyie Zyie added the v8 label Jan 12, 2024
@bigtimebuddy
Copy link
Member

The node/npm versions are spread all over the place as inputs of the setup workflow. It would be easier to manage if you just declared that in one place (or used the input default).

@bigtimebuddy
Copy link
Member

Otherwise, love the modularity of these workflows. Great job!

@Zyie Zyie merged commit b433701 into fix/point-types Jan 15, 2024
4 checks passed
@Zyie Zyie deleted the fix/ci branch January 15, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants