Fix: Culler not accurately culling objects #10123
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1e0896f:
|
| // dont process children if not needed | ||
| if ( | ||
| !container.cullableChildren | ||
| || !container.visible |
There was a problem hiding this comment.
I think this is incorrect. Even when a container is culled with container.visible = false, it's children's visibility must still be set independently for culling to work correctly.
There was a problem hiding this comment.
heya! thanks for pointing out - this should be fine - as visibility is cascaded down the scene graph when we do the transform update.
| // dont process children if not needed | ||
| if ( | ||
| !container.cullableChildren | ||
| || !container.visible |
There was a problem hiding this comment.
heya! thanks for pointing out - this should be fine - as visibility is cascaded down the scene graph when we do the transform update.
No description provided.