-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: support for unsafe eval nad std40 uniform buffers #10124
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added support for wgsl alongside std40 uniform buffers - unified uniforms to all work of uniformTypes - fixed filters that had temp workarounds
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ab75309:
|
- auto generate class files for unsafe eval - make sure the its nice an opitimised!
Zyie
reviewed
Jan 19, 2024
Zyie
changed the title
Chore/wgsl uniform upgrade
Fix: support for unsafe eval nad std40 uniform buffers
Jan 19, 2024
Zyie
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
renamed files to better reflect their purpose
added support for wgsl alongside std40 uniform buffers
unified uniforms to all work of uniformTypes
fixed filters that had temp workarounds
unsafe eval working like a champ now too.
creates cacheing functions and auto generates the code from our uniform generators - so we have one source of truth