Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: support for unsafe eval nad std40 uniform buffers #10124

Merged
merged 11 commits into from
Jan 19, 2024

Conversation

GoodBoyDigital
Copy link
Member

@GoodBoyDigital GoodBoyDigital commented Jan 17, 2024

  • renamed files to better reflect their purpose

  • added support for wgsl alongside std40 uniform buffers

  • unified uniforms to all work of uniformTypes

  • fixed filters that had temp workarounds

  • unsafe eval working like a champ now too.

  • creates cacheing functions and auto generates the code from our uniform generators - so we have one source of truth

- added support for wgsl alongside std40 uniform buffers
- unified uniforms to all work of uniformTypes
- fixed filters that had temp workarounds
@GoodBoyDigital GoodBoyDigital changed the base branch from dev to next-v8 January 17, 2024 18:14
Copy link

codesandbox-ci bot commented Jan 17, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ab75309:

Sandbox Source
pixi.js-sandbox Configuration

@GoodBoyDigital GoodBoyDigital marked this pull request as ready for review January 18, 2024 16:57
tests/visual/visuals.test.ts Outdated Show resolved Hide resolved
@Zyie Zyie changed the title Chore/wgsl uniform upgrade Fix: support for unsafe eval nad std40 uniform buffers Jan 19, 2024
@Zyie Zyie merged commit b78eecb into next-v8 Jan 19, 2024
4 checks passed
@Zyie Zyie deleted the chore/wgsl-uniform-upgrade branch January 19, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants