Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: texture.update() not correctly updating the texture #10133

Merged
merged 4 commits into from
Jan 24, 2024
Merged

Fix: texture.update() not correctly updating the texture #10133

merged 4 commits into from
Jan 24, 2024

Conversation

GoodBoyDigital
Copy link
Member

@GoodBoyDigital GoodBoyDigital commented Jan 19, 2024 •
edited

  • fix issue where updating a texture that has a resource with different dimensions
  • fixed label issue
  • added tests

fixes #10126

@GoodBoyDigital GoodBoyDigital changed the base branch from dev to next-v8 January 19, 2024 12:04
@GoodBoyDigital GoodBoyDigital marked this pull request as ready for review January 19, 2024 12:04
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jan 19, 2024 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8cd60cf:

Sandbox Source
pixi.js-sandbox Configuration

@Zyie Zyie changed the title v8: Fix for texture.update() Fix: for texture.update() Jan 24, 2024
@Zyie Zyie changed the title Fix: for texture.update() Fix: texture.update() not correctly updating the texture Jan 24, 2024
@Zyie Zyie merged commit 422fd33 into next-v8 Jan 24, 2024
4 checks passed
@Zyie Zyie deleted the chore/v8/texture-update branch January 24, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zyie Zyie Zyie approved these changes

Assignees
No one assigned
Labels
v8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GoodBoyDigital @Zyie