Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8 Merge bugs #10147

Merged
merged 4 commits into from
Jan 26, 2024
Merged

v8 Merge bugs #10147

merged 4 commits into from
Jan 26, 2024

Conversation

GoodBoyDigital
Copy link
Member

A few of the PRs were not super compatible introducing a couple of errors. This should fix them!

  • fix some merge issues we saw
  • fixed issue with autoAssignUniforms issue
  • fixed geometry attribute bug

- fixed issue with autoAssignUniforms issue
- fixed geometry attribute bug
Copy link

codesandbox-ci bot commented Jan 24, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0996071:

Sandbox Source
pixi.js-sandbox Configuration

Co-authored-by: Matt Karl <matt@mattkarl.com>
@GoodBoyDigital
Copy link
Member Author

dang it, forgot to regenerate the images :D

@Zyie Zyie merged commit 8cb949c into next-v8 Jan 26, 2024
4 checks passed
@Zyie Zyie deleted the bugfix/v8-merge-issues branch January 26, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants