Fix: types not building correctly #10165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b17786b:
|
| } | ||
|
|
||
| /** | ||
| * For whatever reason when we build the types we get /// <reference types="dist" /> |
There was a problem hiding this comment.
Would be nice to know why this is happening. TS bug or are we implementing something incorrectly?
There was a problem hiding this comment.
agree! do we have any idea?
There was a problem hiding this comment.
I currently have no idea what is causing this, but will add a ticket to look into it some more
Co-authored-by: Matt Karl <matt@mattkarl.com>
bigtimebuddy
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatever reason when we build the types we get
/// <reference types="dist" />This is not what we want, we want
/// <reference types="@webgpu/types" />So i wrote a little script just to replace this out
Also we needed to copy over our
Shader.d.tsfile which defines frag,vert,wgsl files