Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: allow setting bitmap text fill as 0x0 #10188

Merged
merged 4 commits into from
Feb 6, 2024
Merged

Fix: allow setting bitmap text fill as 0x0 #10188

merged 4 commits into from
Feb 6, 2024

Conversation

Zyie
Copy link
Member

@Zyie Zyie commented Feb 6, 2024

fixes: #10175

@Zyie Zyie self-assigned this Feb 6, 2024
@Zyie Zyie added the v8 label Feb 6, 2024
@Zyie Zyie linked an issue Feb 6, 2024 that may be closed by this pull request
Copy link

codesandbox-ci bot commented Feb 6, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4f3f8d9:

Sandbox Source
pixi.js-sandbox Configuration

Copy link

codesandbox-ci bot commented Feb 6, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e5bf20b:

Sandbox Source
pixi.js-sandbox Configuration

Copy link
Member

@GoodBoyDigital GoodBoyDigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Matts suggestion seems good also!

@Zyie Zyie merged commit 5ada567 into next-v8 Feb 6, 2024
4 checks passed
@Zyie Zyie deleted the fix/false-fill branch February 6, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Incorrect Text color
3 participants