Fix: export jpg format error(v8) #10316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a2b9e99:
|
Zyie
changed the title
Zyie
changed the title
| const imageTypes: Record<Formats, string> = { | ||
| png: 'image/png', | ||
| jpg: 'image/jpeg', | ||
| // webp: 'image/webp', |
There was a problem hiding this comment.
Can we enable webp? Was there a reason you disabled?
Also, the Formats type can be simplified to be typeof keyof imageTypes to be less redundant.
There was a problem hiding this comment.
type Formats = 'png' | 'jpg';
Because the current definition is two, we can add more if needed
There was a problem hiding this comment.
Go ahead and just add webp. It is supported with the browser API
Zyie
added
v8
✅ Ready To Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
format is 'image/png' or 'image/jpeg'
add a map