Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: filter is not taking the RenderTexture's frame's offset into account when being applied #10387

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

GoodBoyDigital
Copy link
Member

fixes #10368

visual test added also.

tweak Sprite test to use.. Sprite :)
Copy link

codesandbox-ci bot commented Mar 28, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9b0131a:

Sandbox Source
pixi.js-sandbox Configuration

src/scene/container/bounds/Bounds.ts Outdated Show resolved Hide resolved
@Zyie Zyie changed the title BugFix: [v8] The filter is not taking the RenderTexture's frame's offset into account when being applied Fix: filter is not taking the RenderTexture's frame's offset into account when being applied Apr 2, 2024
@GoodBoyDigital GoodBoyDigital requested a review from Zyie April 2, 2024 15:46
@Zyie Zyie added the v8 label Apr 2, 2024
@Zyie Zyie added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Apr 2, 2024
@Zyie Zyie added this pull request to the merge queue Apr 2, 2024
Merged via the queue into dev with commit 68a810e Apr 2, 2024
4 checks passed
@Zyie Zyie deleted the bugfix/render-texture-frame-filters branch April 2, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t v8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: [v8] The filter is not taking the RenderTexture's frame's offset into account when being applied
3 participants