Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem in existing project:
For v7 I always overrode geometry attributes in constructor:
and that evolved to function that just takes care of buffer:
initGeom() can also used for similar geometries that have same attribute list, but completely different set of fields, i just call
MyGeom.prototype.initGeom.call(this)
know this approach is not possible because attributes has to be passed to
super()
. Thus, I have tothat's certainly not ok , so I added function, again:
thus, initGeom can be used for other geometry classes.
However, that is not passing through typescript, I need
AttributeOptions
exposed to set the type ofinitGeom
manually, it cannot be infered!