Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: tiling sprite transform not updating correctly #10409

Merged
merged 1 commit into from Apr 9, 2024

Conversation

GoodBoyDigital
Copy link
Member

Fixes issue where rotation was not updating the uvs correctly without calling _onTilingSpriteUpdate

fixed with test!

example: https://www.pixiplayground.com/#/edit/-FkV3enddtHBC00QIzYrv

@GoodBoyDigital GoodBoyDigital requested a review from Zyie April 2, 2024 16:14
Copy link

codesandbox-ci bot commented Apr 2, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c036dfa:

Sandbox Source
pixi.js-sandbox Configuration

@Zyie Zyie changed the title fix tiling sprite transform fix: tiling sprite transform not updating correctly Apr 2, 2024
@Zyie Zyie added the v8 label Apr 2, 2024
@Zyie Zyie added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Apr 2, 2024
@Zyie Zyie changed the title fix: tiling sprite transform not updating correctly Fix: tiling sprite transform not updating correctly Apr 9, 2024
@Zyie Zyie added this pull request to the merge queue Apr 9, 2024
Merged via the queue into dev with commit 610c2a3 Apr 9, 2024
4 checks passed
@Zyie Zyie deleted the bugfix/v8-rotating-tiling-sprite branch April 9, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t v8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants