Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: requestVideoFrameCallback being called on wrong object #10415

Merged
merged 1 commit into from Apr 9, 2024

Conversation

Zyie
Copy link
Member

@Zyie Zyie commented Apr 4, 2024

Fixes: #10384

@Zyie Zyie requested a review from GoodBoyDigital April 4, 2024 09:49
@Zyie Zyie added the v8 label Apr 4, 2024
Copy link

codesandbox-ci bot commented Apr 4, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bbd6c24:

Sandbox Source
pixi.js-sandbox Configuration

Copy link
Member

@GoodBoyDigital GoodBoyDigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@Zyie Zyie added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Apr 4, 2024
@Zyie Zyie added this pull request to the merge queue Apr 9, 2024
Merged via the queue into dev with commit de9c4c7 Apr 9, 2024
4 checks passed
@Zyie Zyie deleted the fix/video-resource branch April 9, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t v8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: requestVideoFrameCallback does not seem to be working as expected
3 participants