Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Polygon.__proto__.strokeContains skips checking last line segment when this.closePath false #10423

Merged
merged 2 commits into from Apr 9, 2024
Merged

Fix: Polygon.__proto__.strokeContains skips checking last line segment when this.closePath false #10423

merged 2 commits into from Apr 9, 2024

Conversation

naramdash
Copy link
Contributor

Description of change
Pre-Merge Checklist
  • Tests and/or benchmarks are included (closePath related tests are added)
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

@naramdash naramdash changed the title Fix/close path false polygon stroke contains Fix: close path false polygon stroke contains Apr 7, 2024
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Apr 7, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 74724a8:

Sandbox Source
pixi.js-sandbox Configuration

@naramdash naramdash changed the title Fix: close path false polygon stroke contains Fix: Polygon.__proto__.strokeContains skips checking last line segment when this.closePath false Apr 7, 2024
bigtimebuddy
bigtimebuddy approved these changes Apr 7, 2024
View reviewed changes
Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Thank you.

@Zyie Zyie added v8 ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t labels Apr 8, 2024
@Zyie Zyie added this pull request to the merge queue Apr 9, 2024
Merged via the queue into pixijs:dev with commit 9a8c8e2 Apr 9, 2024
3 checks passed
@naramdash naramdash deleted the fix/closePath-false-polygon-strokeContains branch April 9, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigtimebuddy bigtimebuddy bigtimebuddy approved these changes

Assignees
No one assigned
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t v8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@naramdash @bigtimebuddy @Zyie