fix: destroy renderGroups #10566
Merged
fix: destroy renderGroups #10566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b6dccd8:
|
bigtimebuddy
approved these changes
May 21, 2024
Comment on lines
+227
to
+230
| (this.childrenRenderablesToUpdate as any) = null; | ||
| (this.childrenToUpdate as any) = null; | ||
| (this.renderGroupChildren as any) = null; | ||
| (this._onRenderContainers as any) = null; |
There was a problem hiding this comment.
Take this or leave it, but I think this will avoid the as any casting.
Suggested change
| (this.childrenRenderablesToUpdate as any) = null; | |
| (this.childrenToUpdate as any) = null; | |
| (this.renderGroupChildren as any) = null; | |
| (this._onRenderContainers as any) = null; | |
| Object.assign(this, { | |
| childrenRenderablesToUpdate: null, | |
| childrenToUpdate: null, | |
| renderGroupChildren: null, | |
| _onRenderContainers: null, | |
| }); |
Co-authored-by: Matt Karl <matt@mattkarl.com>
Zyie
added
the
✅ Ready To Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Added a destroy function to renderGroup and also made sure it is called when the container that owns it is destroyed.
Pre-Merge Checklist
npm run lint)npm run test)fixes #10533